Bug fix and enchantment in cygpath.cc
Ilya Bobir
ilya@po4ta.com
Sat May 12 12:48:00 GMT 2007
Corinna Vinschen wrote:
> On Jul 30 16:24, Ilya wrote:
>
>> Corinna Vinschen wrote:
>>
>>> On Jul 29 12:29, Ilya wrote:
>>>
>>>
>>>> This patch is against cygpath.cc 1.42.
>>>> In 1.43 addressed bug was already fixed, but I believe my fix is a bit
>>>> better.
>>>>
>>>> Current fix just returns filename, in case filename is for a nonexistent
>>>> file. I think that internal short to long file name conversion routine
>>>> could be used in this case, because it deals ok with nonexistent files.
>>>>
>>>>
>>> If you could regenerate your patch so that it's against current CVS, I
>>> will take it, since its size will then be below the "trivial fix" rule.
>>> Please see http://cygwin.com/contrib.html, "Before you get started",
>>> second paragraph.
>>>
>>>
>>> Thanks,
>>> Corinna
>>>
>>>
>> No problem :)
>> [...]
>> * cygpath.cc (get_long_name): Fallback to get_long_path_name_w32impl.
>> Properly null-terminate 'buf'.
>>
>
> Thanks. Applied with minor changes.
>
>
> Corinna
>
>
>
I've submitted this patch on 30.07.2006, but it seems that the bug still
exists in cygwin-1.5.24-2 that was released on 31.01.2007.
I can see that HEAD CVS brunch contains the fix.
Why is that so? Is it some kind of mistake?
Ilya Bobir
More information about the Cygwin-patches
mailing list