[Patch] Encode invalid chars in /proc/registry entries

Christian Franke Christian.Franke@t-online.de
Fri Nov 16 19:35:00 GMT 2007

Christopher Faylor wrote:
> ..
>>> Patch is tested with 1.5.24-2. Merge with HEAD looks good, but was not 
>>> actually tested. Therefore, no changelog provided yet.
>> Thanks for this patch.  Apart from the missing ChangeLog I'm inclined
>> to apply it to the upcoming 1.5.25 release, but I don't like to have it
>> in HEAD as is.
> I'm not so sure it's appropriate for either yet.
> Isn't it possible to use at least some of the managed mode functions
> which deal with munging characters to do some of encoding?  It seems
> like the patch duplicates some of the functionality from path.cc.
> I realize that the registry is sort of the opposite of a managed mount
> but it seems like the encoding functions might be potentially used in
> reverse for this.

I actually consulted path.cc before starting the patch but did not find 
any function which provides the required functionality OOTB. Therefore, 
I solved the tradeoff between "reuse" and "do not change working code if 
you don't have time for thorough regression testing" by the latter :-)


More information about the Cygwin-patches mailing list