[patch] un-NT-ify cygcheck (was: cygwin 1.5.25-7: cygcheck does not work?)
Fri Dec 21 03:07:00 GMT 2007
On Fri, Dec 21, 2007 at 01:59:54AM -0000, Dave Korn wrote:
>On 20 December 2007 21:12, Christopher Faylor wrote:
>> On Thu, Dec 20, 2007 at 07:15:53AM -0800, Brian Dessent wrote:
>>> The attached patch un-NT-ifies bloda.cc but sadly a similar cleanup is
>>> still required for cygpath as well if we are to support 9x/ME out of the
>>> 1.5 branch. In that case I suppose you could just revert cygpath.cc to
>>> an older revision before the native APIs were added.
>> I had something similar in my sandbox but 1) you beat me to it and 2)
>> yours is better. So, please check this into the trunk. I don't have
>> any problem with cygcheck being Windows 9x aware since it could help us
>> track down problems with people who are trying to run Cygwin 1.7.x on
>> older systems.
>> Unless Corinna says differently, I think she wants to be in control of
>> what goes into the branch so I don't want to suggest that you should
>> check it in there too.
>But it only belongs on the branch at all, doesn't it? When I wrote
>bloda.cc, I didn't bother with 9x compat, because I was only writing it
>for HEAD, where we have stopped supporting 9x.
>Surely there are many other reasons why HEAD won't work on 9x, so the
>only benefit would be in applying this patch to the branch?
I explained my logic above:
"I don't have any problem with cygcheck being Windows 9x aware since it
could help us track down problems with people who are trying to run
Cygwin 1.7.x on older systems."
The problem in this case would be "Hey! Look at what cygcheck is saying!
You are using Windows 9x! You can't do that!"
OTOH, you could make a case that cygcheck on the trunk should just
consider Windows 9x and friends to be dodgy apps and should issue a
clear error in that case.
More information about the Cygwin-patches