[PATCH?] Separate pthread patches, #2 take 3

Dave Korn dave.korn.cygwin@googlemail.com
Thu Jun 4 03:15:00 GMT 2009


Christopher Faylor wrote:
> On Thu, Jun 04, 2009 at 04:03:03AM +0100, Dave Korn wrote:
>> but it's a horrible bit of code.  Declaring the memory location as input only,
>> then clobbering all of memory and potentially confusing the optimisers with
>> type aliasing casts?  It makes me very uneasy.
> 
> Ok.  I'm convinced.  Please check in whatever you think is best.
> 
> cgf

  I will wait and see what advice the gcc list has to offer on the topic
first.  It may yet cast a new light on things.  (Or it may just confirm my
suspicions that even in trusted and well-tested library code, there has been a
fair deal of ad-hoc-ery and copypastaing of inline asms that people didn't
really grok.)  I'll also see if I can dig up any recent PRs or fixes that
might have a bearing on why we get better code from HEAD than 4.3.

    cheers,
      DaveK



More information about the Cygwin-patches mailing list