[PATCHes] Misc aliasing fixes for building DLL with gcc-4.5.0

Christopher Faylor cgf-use-the-mailinglist-please@cygwin.com
Mon Aug 10 04:05:00 GMT 2009


On Mon, Aug 10, 2009 at 04:11:49AM +0100, Dave Korn wrote:
>	* fhandler_tty.cc (process_input): Add dummy return to silence warning.
>	(process_ioctl): Likewise.

Shouldn't these be defined with __attribute__ ((noreturn))?

>	* fork.cc (cygfork): New name with friendable C++ linkage for ...
>	(fork): ... un-friendable extern "C" function becomes stub calling it.
>	(class frok): Declare cygfork() friend, not fork(), avoiding PR41020.

Ugh.  I don't like this.  fork is slow enough and complicated enough
without adding this kind of workaround.  If this is a problem with
declaring an 'extern "C"' friend function then it should be fixable by
just making fork() a C++ function but exporting it as a "C" function
in cygwin.din.

Also, referring to a bug without explaining what the problem either in
the source code or the ChangeLog is a guaranteed way to cause confusion
tomorrow after a memory cache refresh.

cgf



More information about the Cygwin-patches mailing list