[PATCH] --std=c89 error in sys/signal.h

[Yaakov (Cygwin/X)]

On 29/09/2009 17:33, Christopher Faylor wrote:
>> I see two possible solutions:
>>
>> 1) Unconditionally #include<sys/types.h>  in<sys/signal.h>  (newlib), OR
>> 2) #include<sys/types.h>  in<cygwin/signal.h>.
>>
>> Since this appears to be Cygwin specific, I went for the latter.  Patch
>> attached.
>
> WDLD?

On IRC:

cygwinports: cgf: wtf WDLD?
cgf: What Does Linux Do?
cgf: I adapted it from Dave Korn.
cygwinports: sounds like a candidate for OLOCA

Anyway, to answer the question, AFAICS in glibc, <signal.h> #include 
<bits/types.h> unconditionally[1].  (<sys/signal.h> is just one line: 
#include <signal.h> [2])

So should I take the first route, patching newlib instead?


Yaakov

[1] http://repo.or.cz/w/glibc.git?a=blob;f=signal/signal.h;hb=HEAD
[2] http://repo.or.cz/w/glibc.git?a=blob;f=signal/sys/signal.h;hb=HEAD