Merge pseudo-reloc-v2 support from mingw/pseudo-reloc.c

Corinna Vinschen
Wed Oct 7 07:50:00 GMT 2009

On Oct  6 23:03, Christopher Faylor wrote:
> On Tue, Oct 06, 2009 at 08:14:59PM -0400, Charles Wilson wrote:
> >I just figured it made sense to split up the ChangeLog, because I didn't
> >want to take credit for Kai's changes, but I did want to document what I
> >did, beyond the mingw/ version (which should make it easier when I
> >submit THOSE changes back to the mingw folks).  Furthermore, I figure
> >somebody might scan the ChangeLog looking for people without a Red Hat
> >copyright assignment, and get nervous if they saw:
> >
> >date  Charles Wilson  <...>  <<--- has assignment
> >      Kai Teitz  <...>       <<--- no assignment (?)
> >
> >      A bunch of changes
> >
> >The way I split the ChangeLog up, it is clear that Kai only touched the
> >public domain file.
> >
> >Anyway, once I had split up the ChangeLog, I simply wondered if I should
> >/also/ split up the commits.  If you're happy with one-big-lump, so am I
> >-- that's easier.
> I think this one is Corinna's call.

Make the checkin and the ChangeLog one lump.  The ChangeLog entry is
about the work done to put this stuff into Cygwin, which was your work.
Don't repeat the mingw entry, rather just say that you imported from
there and credit Kai with that entry.

Something like this.  Just subsume three paragraphs in one single
ChangeLog entry:

  2009-99-99  Charles "Pseudo-Reloc" Wilson  <...>

  	Additional pseudo-reloc-v2 support.
	* ntdll.h: [...]

	Cygwin modifications to pseudo-reloc.c.
	* lib/pseudo-reloc.c: [...]

	* lib/pseudo-reloc.c: Import new implementation to support
	v2 pseudo-relocs implemented by Kai Tietz from mingw.


Corinna Vinschen                  Please, send mails regarding Cygwin to
Cygwin Project Co-Leader          cygwin AT cygwin DOT com
Red Hat

More information about the Cygwin-patches mailing list