Sync pseudo-reloc.c, round #2

Charles Wilson cygwin@cwilson.fastmail.fm
Sun Oct 25 19:30:00 GMT 2009


After the previous synchronization between cygwin and mingw, I took the
result back to the mingw64 guys:
https://sourceforge.net/tracker/?func=detail&atid=983355&aid=2885246&group_id=202880

Merging with them required a few additional changes, so now I'm bringing
that result back to cygwin (and mingw32). There are no functional
changes here, at least as far as cygwin is concerned.

(a) more uniform handling of errors (mingw[32|64] now more like cygwin)
(b) no more need for assert() nor assert.h
(c) on mingw[32|64], all errors now result in an error message, just
like cygwin -- followed by an abort (CW_EXIT_PROCESS, for cygwin).

Tested on mingw32 and cygwin.

2009-10-25  Charles Wilson  <...>

        Sync pseudo-reloc.c with mingw64
	* lib/psuedo-reloc.c: Remove unnecessary includes.
	Forward declare _pei386_runtime_relocator.
	Decorate _image_base__ symbol with macro for
	mingw64 compatibility. Whitespace changes.
	(__print_reloc_error): Renamed to...
	(__report_error): This. "Returns" void, and
	always aborts. Now used on all platforms.
	(__write_memory): Remove special case error handling
	for different platforms - always call __report_error.
	(do_pseudo_reloc): Remove special case error handling
	for different platforms - always call __report_error.
	(_pei386_runtime_relocator): Decorate _image_base__
	symbol with mingw64 compatibility macro.

OK to commit?

--
Chuck
-------------- next part --------------
A non-text attachment was scrubbed...
Name: cygwin-pseudo-reloc-round2.patch
Type: application/x-patch
Size: 8976 bytes
Desc: not available
URL: <http://cygwin.com/pipermail/cygwin-patches/attachments/20091025/15bfcb52/attachment.bin>


More information about the Cygwin-patches mailing list