patch: sleep/nanosleep bug

Christopher Faylor cgf-use-the-mailinglist-please@cygwin.com
Wed Nov 18 20:48:00 GMT 2009


On Wed, Nov 18, 2009 at 01:13:53PM -0700, Eric Blake wrote:
>2009-11-18  Eric Blake  <ebb9@byu.net>
>
>	* signal.cc (nanosleep): Support 'infinite' sleep times.
>	(sleep): Avoid uninitialized memory.

Sorry but, while I agree with the basic idea, this seems like
unnecessary use of recursion.  It seems like you could accomplish the
same thing by just putting the cancelable_wait in a for loop.  I think
adding recursion here obfuscates the function unnecesarily.

cgf



More information about the Cygwin-patches mailing list