[Patch] override-able installation_root

Corinna Vinschen corinna-cygwin@cygwin.com
Thu Nov 26 12:47:00 GMT 2009


On Nov 26 22:56, Shaddy Baddah wrote:
> Hi,
> 
> Corinna Vinschen wrote:
> >Sorry, but no.  We won't accept this patch.  We have deliberately chosen
> >to get away from the dependency to the Windows registry, and we really
> >don't want to add it back again.
> Thank you for the response. Fair enough. But is it no to the idea of
> an overridable installation_root, or to doing by way of a registry
> setting? Is there another way to do this that would be reasonable?
> Say the use of an environment variable? Other?

Don't know yet, but certainly not an environment variable since these
are read after the installation root has been handled.  And again, this
isn't something for 1.7.1.

> >Btw., for a non-trivial patch like this you need to file a copyright
> >assignment.  See http://cygwin.com/contrib.html, the "Before you get
> >started" section.
> Fair enough. I estimated that it was trivial, but I accept that it isn't.

Trivial are very small patches, usually < 10 lines.  They also should
only fix something, not add new features.

> >That's on my TODO list and PTC.  It will have to wait until after 1.7.1
> >as well, though.
> I'll ask around about copyright assignment. If I can get that
> sorted, I'll try and help with that effort.

Just use the copyright asignment form at http://cygwin.com/assign.txt


Corinna

-- 
Corinna Vinschen                  Please, send mails regarding Cygwin to
Cygwin Project Co-Leader          cygwin AT cygwin DOT com
Red Hat



More information about the Cygwin-patches mailing list