patch: sleep/nanosleep bug
Thu Nov 26 16:54:00 GMT 2009
On Thu, Nov 26, 2009 at 12:21:21PM +0100, Corinna Vinschen wrote:
>On Nov 25 06:11, Eric Blake wrote:
>> -----BEGIN PGP SIGNED MESSAGE-----
>> Hash: SHA1
>> According to Eric Blake on 11/20/2009 7:15 AM:
>> >>> * signal.cc (nanosleep): Support 'infinite' sleep times.
>> >>> (sleep): Avoid uninitialized memory.
>> >> Sorry but, while I agree with the basic idea, this seems like
>> >> unnecessary use of recursion. It seems like you could accomplish the
>> >> same thing by just putting the cancelable_wait in a for loop. I think
>> >> adding recursion here obfuscates the function unnecesarily.
>> > How about the following, then? Same changelog.
>Do you think we need it in 1.7.1?
No, I don't think so. I'll get to this after Thanksgiving.
More information about the Cygwin-patches