Cygwin Filesystem Performance degradation 1.7.5 vs 1.7.7, and methods for improving performance

Christopher Faylor cgf-use-the-mailinglist-please@cygwin.com
Mon Sep 6 15:25:00 GMT 2010


Thanks for the patch and for all of the work you put into it.

On Mon, Sep 06, 2010 at 03:24:09PM +0200, Corinna Vinschen wrote:
>The patch is also missing a ChangeLog entry.  I only took a quick glance
>over the patch itself.  The code doesn't look correctly formatted in GNU
>style.  Also, using the diff -up flags would be helpful.

And, this is the type of patch which would be better served if submitted
in small chunks.  You have multiple changes in your 1158 line patch and
they don't seem to all be interrelated.

Also, in addition to formatting concerns, you don't seem to have used
comments very much.  Corinna and I have been making a concerted effort
to comment changes more thoroughly so it would be nice if your patch
contained more of those.

I didn't look at the patch very closely either since there are copyright
issues but some of your conclusions don't seem right to me.  I agree
with Corinna's response.

cgf



More information about the Cygwin-patches mailing list