[PATCH] Add fenv.h and support.

Dave Korn dave.korn.cygwin@gmail.com
Sat Sep 11 00:20:00 GMT 2010


On 10/09/2010 22:43, Christopher Faylor wrote:

> Looks nice to me with one HUGE caveat:  Please maintain the pseudo-sorted
> order in cygwin.din.  Sorry to have to impose this burden on you.

  No, that's fine; I've never been sure whether we need to care about the
ordinal numbers or not in that file.  (AFAIK, we don't have any realistic
scenarios where anyone would be linking against the Cygwin DLL by ordinal
imports, but I hate making assumptions based only on my own limited experience...)

> Other than that, please check in and thanks for the patch.  It was obviously
> a lot of work.

  Heh, actually not all that much.  I had one of those in-the-zone moments and
did both this and the gnu ld plugin infrastructure in one ~20h no-sleep coding
binge, then spent another few hours tidying it up after I'd slept a bit!

  So, I'll fix the cygwin.din and check in shortly.  Thanks for reviewing.

  (BTW, the request for advice re: automated compliance checking stands; I
would really like to run some proper formal testsuites against this, even if
they don't fully work on Cygwin.  Eric, surely you've looked at this stuff?  I
was certainly hoping so, anyway!)

    cheers,
      DaveK



More information about the Cygwin-patches mailing list