[PATCH] Fix bogus fsync() error

Corinna Vinschen corinna-cygwin@cygwin.com
Tue Feb 1 08:47:00 GMT 2011


On Jan 31 20:44, Christian Franke wrote:
> If used on raw devices like /dev/sda fsync() always fails with
> EBADRQC (54) because FlushFileBuffers() always fails with
> ERROR_INVALID_FUNCTION (1).
> 
> The attached patch fixes this by simply ignoring this error in the
> fhandler_base implementation. This should not affect any real flush
> errors which likely would return other error codes.
> 
> An alternative approach would be to ignore the error only in a new
> fhandler_raw_dev/floppy::fsync(). IMO not worth the effort is this
> case.

I agree.  I applied the patch.


Thanks,
Corinna

-- 
Corinna Vinschen                  Please, send mails regarding Cygwin to
Cygwin Project Co-Leader          cygwin AT cygwin DOT com
Red Hat



More information about the Cygwin-patches mailing list