[PATCH] False positive from access("/proc/registry/...", F_OK)

[Christian Franke]

Corinna Vinschen wrote:
> On Apr 27 12:26, Christian Franke wrote:
>    
>> access("/proc/registry/...", F_OK) returns 0 for all (including
>> nonexistent) entries below a registry key which cannot be opened:
>>
>> ...
>>
>> Problem was likely introduced by fhandler_registry.cc change 1.52:
>>
>>   fhandler_registry::exists ()
>>   ...
>>     if (!val_only)
>>       hKey = open_key (path, KEY_READ, wow64, false);
>>   - if (hKey != (HKEY) INVALID_HANDLE_VALUE)
>>   + if (hKey != (HKEY) INVALID_HANDLE_VALUE || get_errno () == EACCES)
>>       file_type = 1;
>>     else
>>
>> open_key() returns INVALID_HANDLE_VALUE and EACCESS also if an upper
>> level key cannot be opened. The exists() function returns 1
>> (virt_directory) then, it should return 0 (virt_none).
>>      
> I don't remember anymore why I did that and naturally I also didn't
> write a comment.
>
> But what you say sounds right to me.  Please create a patch.
>
>    

Done, tested and attached.

Christian

-------------- next part --------------
A non-text attachment was scrubbed...
Name: registry-fix-eacces.patch
Type: text/x-patch
Size: 1273 bytes
Desc: not available
URL: <http://cygwin.com/pipermail/cygwin-patches/attachments/20110504/920950a8/attachment.bin>