[PATCH] False positive from access("/proc/registry/...", F_OK)
Wed May 4 20:10:00 GMT 2011
Corinna Vinschen wrote:
> On Apr 27 12:26, Christian Franke wrote:
>> access("/proc/registry/...", F_OK) returns 0 for all (including
>> nonexistent) entries below a registry key which cannot be opened:
>> Problem was likely introduced by fhandler_registry.cc change 1.52:
>> fhandler_registry::exists ()
>> if (!val_only)
>> hKey = open_key (path, KEY_READ, wow64, false);
>> - if (hKey != (HKEY) INVALID_HANDLE_VALUE)
>> + if (hKey != (HKEY) INVALID_HANDLE_VALUE || get_errno () == EACCES)
>> file_type = 1;
>> open_key() returns INVALID_HANDLE_VALUE and EACCESS also if an upper
>> level key cannot be opened. The exists() function returns 1
>> (virt_directory) then, it should return 0 (virt_none).
> I don't remember anymore why I did that and naturally I also didn't
> write a comment.
> But what you say sounds right to me. Please create a patch.
Done, tested and attached.
-------------- next part --------------
A non-text attachment was scrubbed...
Size: 1273 bytes
Desc: not available
More information about the Cygwin-patches