Mon May 9 08:16:00 GMT 2011
On May 8 17:48, Yaakov (Cygwin/X) wrote:
> This implements the POSIX clock_settime function, on top of settimeofday:
> The fixes to settimeofday are necessary both to match BSD and Linux behaviour,
> and to provide the errnos and return status for clock_settime required by POSIX.
> I also fixed posix.sgml WRT clock_setres.
> Patches for winsup/cygwin and winsup/doc, plus test programs for both
> functions, attached.
Thanks for the patch.
> Index: times.cc
> RCS file: /cvs/src/src/winsup/cygwin/times.cc,v
> retrieving revision 1.107
> diff -u -r1.107 times.cc
> --- times.cc 2 May 2011 15:28:35 -0000 1.107
> +++ times.cc 8 May 2011 17:55:34 -0000
> @@ -111,6 +111,12 @@
> tz = tz; /* silence warning about unused variable */
> + if (tv->tv_usec < 0 || tv->tv_usec >= 1000000)
Not your fault, but what I'm missing in settimeofday is an EFAULT handler.
Could you please add one, just like in the times() function a couple of
lines earlier? The `tz = tz;' line can go away, the usage is covered
by the syscall_printf at the end of the function.
Other than that, please apply.
Corinna Vinschen Please, send mails regarding Cygwin to
Cygwin Project Co-Leader cygwin AT cygwin DOT com
More information about the Cygwin-patches