[PATCH] suggestion for faster pseudo-reloc.

Jin-woo Ye jojelino@gmail.com
Sun Sep 2 17:51:00 GMT 2012

On 2012-09-02 PM 7:27, Corinna Vinschen wrote:
> Hi Jin-woo,
> On Aug 26 10:59, Jin-woo Ye wrote:
>> This patch fixes the problem making pseudo-reloc too slow when there
>> is many pseudo-reloc entries in rdata section by deciding when not
>> to call Virtual{Query,Protect} to save overhead.
>> I tested this patch and time taken for pseudo-reloc reduced 1800ms
>> to 16ms for 3682 entries.
>> Please review this patch.
> Done.  The idea is good, but I wasn't quite happy with your code.  It's
> hard to read and it's more complicated than necessary.  For instance,
> you only handle one page at a time, but your code keeps an array for two
> page information entries around for no good reason.
> I checked in a simplified version of your patch.  Please have a look.
> Since the code in question is in the public domain, it doesn't require
> a Cygwin copyright assignment.
> Thanks,
> Corinna
Now it is clear that this patch would be needed other relevant projects 
such as mingw, mingw-w64. thanks for your effort on simplified one.


More information about the Cygwin-patches mailing list