[PATCH] Fix some debug string format specifiers.

Corinna Vinschen corinna-cygwin@cygwin.com
Tue Jan 7 15:06:00 GMT 2014


On Dec 22 00:39, Ray Donnelly wrote:
> I hope patches generated with git are OK?

In theory, yes, but please attach them inline to the mail, otherwise
they won't show up in the reply with some mailers, so it's a hassle
to discuss them.

As for this patch, did you actually test it?

-	len = sprintf(dbuf, "[mcleanup1] kcount 0x%x ssiz %d\n",
+	len = sprintf(dbuf, "[mcleanup1] kcount 0x%p ssiz %zd\n",

%p implies printing the 0x prefix, so this results in twice the prefix.

-                       "[mcleanup2] frompc 0x%x selfpc 0x%x count %d\n" ,
+                       "[mcleanup2] frompc 0x%zd selfpc 0x%zd count %zd\n" ,

0x prefix and 'd' format specifier?


Corinna

-- 
Corinna Vinschen                  Please, send mails regarding Cygwin to
Cygwin Maintainer                 cygwin AT cygwin DOT com
Red Hat
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 819 bytes
Desc: not available
URL: <http://cygwin.com/pipermail/cygwin-patches/attachments/20140107/fd710250/attachment.sig>


More information about the Cygwin-patches mailing list