[PATCH][RFC] POSIX barrier implementation, take 1

Corinna Vinschen corinna-cygwin@cygwin.com
Thu Feb 11 13:57:00 GMT 2016

Hi Václav,

On Feb 11 14:30, Václav Haisman wrote:
> Hi.
> I am attaching a patch that adds (or tries to) POSIX barriers
> implementation into Cygwin. I have compiled it but not actually tested
> it, yet. I am dumping it here just in case I get run over by a bus on
> my way home. :)

Uh oh, please don't do that.

I took a quick glance and your code looks pretty well.  Your
introduction of LIKELY/UNLIKELY is a neat step as well.  Shouldn't that
go into some generic header rather than just into thread.cc so we can
use it more librally throughout?

Btw., I wouldn't be unhappy if you'd have a more stern look into the
pthread implementation apart from barriers.  There are probably more


Corinna Vinschen                  Please, send mails regarding Cygwin to
Cygwin Maintainer                 cygwin AT cygwin DOT com
Red Hat
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: not available
URL: <http://cygwin.com/pipermail/cygwin-patches/attachments/20160211/e36cb7b6/attachment.sig>

More information about the Cygwin-patches mailing list