[PATCH] Multiple timer issues + new [PATCH]

Corinna Vinschen corinna-cygwin@cygwin.com
Fri Feb 19 11:08:00 GMT 2016

On Feb 19 00:39, Irányossy Knoblauch Artúr wrote:
> Hi,
> On Thu, Feb 18, 2016 at 12:28 PM, Corinna Vinschen
> <corinna-cygwin@cygwin.com> wrote:
> > Would you mind terribly to send a copyright assignment per
> > https://cygwin.com/contrib.html?  If you send it as PDF by mail it takes
> > usually just a few days to be countersigned.
> OK, I will try my best. :-)

It's really simple, trust me :)

> I could not find any information regarding what the names 'gtod' and
> 'ntod' are supposed to mean, and their type names, hires_ms and
> hires_ns, respectively, aren't conveying that 'ntod' is monotonic
> while 'gtod' isn't.

Yeah, right.  Keep in mind that the original times.cc is from pre-2000
and hires.h is from 2002.  Way back when, source comments were
unnecessary because, as we all well know, source is self-documenting...

These days, I think what we should do here is

a) ignore the names and maybe even bulk-rename variables and types
   to something more speaking (rel_timer, abs_timer or whatever)

b) add comments, comments, comments.

> Also, as I have been writing this mail, I have noticed that there is
> still a data race left in the prime() function, so I have made a patch
> for that, too.

Cool, thank you!


Corinna Vinschen                  Please, send mails regarding Cygwin to
Cygwin Maintainer                 cygwin AT cygwin DOT com
Red Hat
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: not available
URL: <http://cygwin.com/pipermail/cygwin-patches/attachments/20160219/93fc24a8/attachment.sig>

More information about the Cygwin-patches mailing list