[PATCH] gprof profiling of multi-threaded Cygwin programs, ver 2

Jon Turney jon.turney@dronecode.org.uk
Mon Feb 22 17:56:00 GMT 2016


On 22/02/2016 16:55, Corinna Vinschen wrote:
> On Feb 22 16:14, Jon Turney wrote:
>> On 22/02/2016 14:25, Corinna Vinschen wrote:
>>> On Feb 22 11:44, Jon Turney wrote:
>>>> Thanks for this.  A few comments inline.
>>>> [...]
>>>> On 20/02/2016 08:16, Mark Geisert wrote:
>>>>> +      // record profiling samples for other pthreads, if any
>>>>> +      cygwin_internal (CW_CYGHEAP_PROFTHR_ALL, profthr_byhandle);
>>>>> +
>>>>
>>>> Hmm.. so why isn't this written as cygheap_profthr_all (profthr_byhandle) ?
>>>
>>> I asked for it:
>>> https://cygwin.com/ml/cygwin-patches/2016-q1/msg00028.html
>>
>> Ok.  I guess I don't understand why it's exported at all in that version of
>> the patch.
>
> I don't understand the question.  cygheap_profthr_all isn't exported
> anymore in v2.

I wasn't taking into account the fact that profil.c gets built into a 
separate library, libgmon.a.

So that clears up my misunderstanding as to why this operation needs to 
be exposed outside the DLL at all.



More information about the Cygwin-patches mailing list