[PATCH] Cygwin: define byteswap.h inlines as macros

Yaakov Selkowitz yselkowitz@cygwin.com
Tue Mar 15 09:41:00 GMT 2016


On 2016-03-15 04:22, Corinna Vinschen wrote:
> On Mar 15 04:14, Yaakov Selkowitz wrote:
>> On 2016-03-15 04:03, Corinna Vinschen wrote:
>>> On Mar 14 22:13, Yaakov Selkowitz wrote:
>>>> The bswap_* "functions" are macros in glibc, so they may be tested for
>>>> by the preprocessor (e.g. #ifdef bswap_16).
>>> ACK.
>>>
>>> While we're at it, what about converting the types to implicit types
>>> (__uint16_t, __uint32_t, __uint64_t).
>>
>> glibc uses short/int/long long for these, so I think we should leave them.
>
> bits/byteswap.h uses __uint64_t, but you're right for the smaller types.

I was looking at a cross-glibc, so that must be a recent change (unless 
you're not looking at x86_64).

-- 
Yaakov



More information about the Cygwin-patches mailing list