[PATCH 09/11] Add c++14 sized deallocation operator

Corinna Vinschen corinna-cygwin@cygwin.com
Mon Mar 21 18:09:00 GMT 2016


On Mar 21 13:46, Peter Foley wrote:
> On Mon, Mar 21, 2016 at 1:13 PM, Corinna Vinschen
> <corinna-cygwin@cygwin.com> wrote:
> > But we export these functions as fallback functions to the applications.
> > See libstdcxx_wrapper.cc and the end of cxx.cc.  While the comment in
> > cxx.cc claims that this should "not be used in practice", there might be
> > c++14 code ending up with undefined references to the new delete
> > operator, isn't it?
> >
> > https://cygwin.com/ml/cygwin-patches/2009-q3/msg00010.html outlines
> > why these exports were necessary in the first place.
> 
> Ah, I'll look into updating those files as well then.

I realized that your orignal patch isn't invalidated by this so I tried
to apply it and we could then add the other stuff later.  However, it
doesn't compile due to a warning, and since we're always building with
-Werror...

[...]/cxx.cc:33:1: error: ‘void operator delete(void*, size_t)’ is a usual (non-placement) deallocation function in C++14 (or with -fsized-deallocation) [-Werror=c++14-compat]
 operator delete (void *p, size_t)
 ^
cc1plus: all warnings being treated as errors

I'm not sure it's the right thing to switch to C++14 by default using
gcc 5.3 yet.


Corinna

-- 
Corinna Vinschen                  Please, send mails regarding Cygwin to
Cygwin Maintainer                 cygwin AT cygwin DOT com
Red Hat
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: not available
URL: <http://cygwin.com/pipermail/cygwin-patches/attachments/20160321/258bbf24/attachment.sig>


More information about the Cygwin-patches mailing list