[PATCH 1/4] Use high-resolution timebases for select().

Corinna Vinschen corinna-cygwin@cygwin.com
Fri May 20 11:20:00 GMT 2016

On May 18 19:14, cgull@glup.org wrote:
> From: John Hood <cgull@glup.org>
> * select.h: Change prototype for select_stuff::wait() for larger
>   microsecond timeouts.
> * select.cc (pselect): Convert from old cygwin_select().
>   Implement microsecond timeouts.
>   (cygwin_select): Rewrite as a wrapper on pselect().
>   (select): Implement microsecond timeouts.
>   (select_stuff::wait): Implement microsecond timeouts with a timer
>   object.

I was just about applying this patch when I noticed a problem.  It's not
a biggy, but you're using standard printf format specifiers while our
debug printf statements use a somewhat different set, i.e:

> +	    select_printf ("to NULL, us %lld", us);

There's no %lld in our debug printf stuff.  That would have to be %D
with uppercase D.

Have a look at smallprint.cc line 94ff, please.

I fixed that locally and applied your patches, excluding the debug
additions from patch 3 for now.


Corinna Vinschen                  Please, send mails regarding Cygwin to
Cygwin Maintainer                 cygwin AT cygwin DOT com
Red Hat
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: not available
URL: <http://cygwin.com/pipermail/cygwin-patches/attachments/20160520/be0dc5ec/attachment.sig>

More information about the Cygwin-patches mailing list