[PATCH 1/4] dlopen: switch to new pathfinder class

Corinna Vinschen corinna-cygwin@cygwin.com
Thu Sep 8 11:59:00 GMT 2016

On Sep  2 13:36, Michael Haubenwallner wrote:
> On 09/02/2016 10:52 AM, Corinna Vinschen wrote:
> > On Sep  2 10:05, Michael Haubenwallner wrote:
> >> Moving the allocator into pathfinder would work then, but still the
> >> tmp_pathbuf instance to use has to be provided as reference.
> > 
> > Hmm, considering that a function calling your pathfinder *might*
> > need a tmp_pathbuf for its own dubious purposes, this makes sense.
> > That could be easily handled via the constructor I think:
> > 
> >   tmp_pathbuf tp;
> >   pathfinder finder (tp);
> > 
> > Still, since I said I'm willing to take this code as is, do you want me
> > to apply it this way for now or do you want to come up with the proposed
> > changes first?
> As I do prefer both pathfinder and vstrlist to not know about tmp_pathbuf
> in particular but a generic memory provider only: Yes, please apply as is.

Done, minus patch 4.  I still think that there should be only a single
pathfinder object and the rest encapsulated within and called via some
pathfinder member function.  I'll look into it later this year.


Corinna Vinschen                  Please, send mails regarding Cygwin to
Cygwin Maintainer                 cygwin AT cygwin DOT com
Red Hat
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: not available
URL: <http://cygwin.com/pipermail/cygwin-patches/attachments/20160908/74c9b681/attachment.sig>

More information about the Cygwin-patches mailing list