[PATCH] describe new locale modifier @cjkwide for user guide
Corinna Vinschen
corinna-cygwin@cygwin.com
Thu Mar 8 07:56:00 GMT 2018
On Mar 8 00:30, Thomas Wolff wrote:
> From 725e49a16c7867512635e6ade0f1ff1e01f8e7c5 Mon Sep 17 00:00:00 2001
> From: Thomas Wolff <towo@towo.net>
> Date: Thu, 8 Mar 2018 00:29:25 +0100
> Subject: [PATCH] describe new locale modifier @cjkwide for user guide
>
> ---
> winsup/doc/setup-locale.xml | 13 +++++++++++++
> 1 file changed, 13 insertions(+)
>
> diff --git a/winsup/doc/setup-locale.xml b/winsup/doc/setup-locale.xml
> index 29502a2..249c125 100644
> --- a/winsup/doc/setup-locale.xml
> +++ b/winsup/doc/setup-locale.xml
> @@ -166,6 +166,19 @@ can be used to force wcwidth/wcswidth to return 1 for the ambiguous width
> characters.
> </para></listitem>
>
> +<listitem><para>
> +For the same class of "CJK Ambiguous Width" characters, it may be
> +desirable to handle them as double-width even when a non-CJK language
> +setting is selected. This supports e.g. certain graphic symbols used
> +by "Powerline" and provided by "Powerline fonts". Some terminals have
> +options to enforce this width handling (xterm -cjk_width,
> +mintty -o Charwidth=ambig-wide, putty configuration) but that alone
> +makes character rendering and locale information inconsistent for those
> +characters. The locale modifier "@cjkwide" supports consistent locale
> +response with this option; it forces wcwidth/wcswidth to return 2 for the
> +ambiguous width characters.
> +</para></listitem>
> +
> </itemizedlist>
>
> </sect2>
> --
> 2.16.2
The patch introduces lots of whitespace errors. Check for yourself.
Remove the patch from your repo and reapply it, e.g., assuming this
patch is HEAD:
$ git reset --hard HEAD~1
$ git am 0001-describe-new-locale-modifier-cjkwide-for-user-guide.patch
Applying: describe new locale modifier @cjkwide for user guide
.git/rebase-apply/patch:14: trailing whitespace.
For the same class of "CJK Ambiguous Width" characters, it may be
.git/rebase-apply/patch:15: trailing whitespace.
desirable to handle them as double-width even when a non-CJK language
.git/rebase-apply/patch:16: trailing whitespace.
setting is selected. This supports e.g. certain graphic symbols used
.git/rebase-apply/patch:17: trailing whitespace.
by "Powerline" and provided by "Powerline fonts". Some terminals have
.git/rebase-apply/patch:18: trailing whitespace.
options to enforce this width handling (xterm -cjk_width,
warning: squelched 4 whitespace errors
warning: 9 lines add whitespace errors.
$ git show
I fixed this locally before pushing, so this is just a friendly hint for
next time.
Pushed.
Thanks,
Corinna
--
Corinna Vinschen Please, send mails regarding Cygwin to
Cygwin Maintainer cygwin AT cygwin DOT com
Red Hat
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: not available
URL: <http://cygwin.com/pipermail/cygwin-patches/attachments/20180308/bb71b7df/attachment.sig>
More information about the Cygwin-patches
mailing list