[PATCH] Posix asynchronous I/O support, part 2

[Corinna Vinschen]

On Mar 28 22:31, Mark Geisert wrote:
> ---
>  winsup/cygwin/include/aio.h | 78 +++++++++++++++++++++++++++++++++++++++++++++
>  1 file changed, 78 insertions(+)
>  create mode 100644 winsup/cygwin/include/aio.h

Ah, not quite ok, I have a nit here:

> diff --git a/winsup/cygwin/include/aio.h b/winsup/cygwin/include/aio.h
> new file mode 100644
> index 000000000..d6ca56517
> --- /dev/null
> +++ b/winsup/cygwin/include/aio.h
> +#ifdef __cplusplus
> +#define restrict /* meaningless in C++ */
> [...]
> +int     lio_listio  (int, struct aiocb *restrict const [restrict], int,
> +                        struct sigevent *restrict);
> +
> +#ifdef __cplusplus
> +}
> +#undef restrict
> +#endif

Don't do that.  Use __restrict instead.  Your header might have to
include sys/cdefs.h, but I guess the other includes already do that
for you.


Corinna

-- 
Corinna Vinschen                  Please, send mails regarding Cygwin to
Cygwin Maintainer                 cygwin AT cygwin DOT com
Red Hat
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: not available
URL: <http://cygwin.com/pipermail/cygwin-patches/attachments/20180404/c047da23/attachment.sig>