[PATCH] Cygwin: af_unix_spinlock_t: add initializer

Corinna Vinschen corinna-cygwin@cygwin.com
Thu Jan 10 18:02:00 GMT 2019


On Jan 10 17:56, Ken Brown wrote:
> Also fix a typo.
> ---
>  winsup/cygwin/fhandler.h | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/winsup/cygwin/fhandler.h b/winsup/cygwin/fhandler.h
> index d02b9a913..7e460701c 100644
> --- a/winsup/cygwin/fhandler.h
> +++ b/winsup/cygwin/fhandler.h
> @@ -832,9 +832,10 @@ class fhandler_socket_local: public fhandler_socket_wsock
>  /* Sharable spinlock with low CPU profile.  These locks are NOT recursive! */
>  class af_unix_spinlock_t
>  {
> -  LONG  locked;          /* 0 oder 1 */
> +  LONG  locked;          /* 0 or 1 */

Huh.

>  public:
> +  af_unix_spinlock_t () : locked (0) {}

Why do we need that?  The spinlock is created as part of a shared mem
region which gets initialized to all zero, no?  Or do you plan to use it
outside of this scenario?


Corinna

-- 
Corinna Vinschen
Cygwin Maintainer
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: not available
URL: <http://cygwin.com/pipermail/cygwin-patches/attachments/20190110/67abb756/attachment.sig>


More information about the Cygwin-patches mailing list