[PATCH] Cygwin: fork: remember child as late as possible

Corinna Vinschen corinna-cygwin@cygwin.com
Fri Apr 12 17:58:00 GMT 2019


On Apr 12 15:31, Michael Haubenwallner wrote:
> Otherwise, when the child does fail to reload dlls and terminates, we
> produce a SIGCHILD signal, even if we did not succeed in starting up the
> child process at all.  Also, we would need to reap that child somewhere.

I'm not that happy with the patch.  The patch is doing two things, one
is to remember child as late as possible, the other is to change the
child startup in case the parent loaded dlls.

Either write a more descriptive commit message or split this into two
patches.  I'd prefer two patches.  It may help debugging.


Thanks,
Corinna

-- 
Corinna Vinschen
Cygwin Maintainer
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: not available
URL: <http://cygwin.com/pipermail/cygwin-patches/attachments/20190412/bee855ba/attachment.sig>


More information about the Cygwin-patches mailing list