[PATCH 4/4] Cygwin: pty: Limit API hook to the program linked with the APIs.

[Corinna Vinschen]

Hi Takashi,

On Sep  4 21:39, Takashi Yano wrote:
> Hi Corinna,
> 
> On Wed, 4 Sep 2019 12:03:51 +0200
> Corinna Vinschen wrote:
> > I'll push the other 3 patches from this series.  For this patch,
> > I wonder why you create set_ishybrid_and_switch_to_pcon while
> > at the same time define a macro CHK_CONSOLE_ACCESS with identical
> > functionality.
> 
> Yah, indeed!
> 
> > Suggestion: Only define set_ishybrid_and_switch_to_pcon() as
> > inline function (probably in winsup.h) and use only this througout.
> 
> This function uses static variable isHybrid (sorry camelback again)
> and static function set_switch_to_pcon() defined in fhandler_tty.cc.
> 
> To make it inline, a lot of changes will be necessary. How about
> non-inline function?

That will add extra function calls, but, yeah, sure.  We can streamline
this later.


Thanks,
Corinna

-- 
Corinna Vinschen
Cygwin Maintainer
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: not available
URL: <http://cygwin.com/pipermail/cygwin-patches/attachments/20190904/685b4bef/attachment.sig>