[PATCH v2] Cygwin: pty: Revise code waiting for forwarding again.
Thu Jan 23 15:02:00 GMT 2020
On Thu, 23 Jan 2020 13:51:54 +0100
Corinna Vinschen wrote:
> On Jan 23 13:30, Takashi Yano wrote:
> > - After commit 6cc299f0e20e4b76f7dbab5ea8c296ffa4859b62, outputs of
> > cygwin programs which call both printf() and WriteConsole() are
> > frequently distorted. This patch reverts waiting function to dumb
> > Sleep().
> I understand the need for this change, but isn't there any other
> way to detect if the pseudo console being ready? E. g., something
> in the HPCON_INTERNAL struct or so?
In any case, this patch has a problem that windows native program takes
a very long time to start/stop after the window size is changed.
Please do not apply this patch.
If you want to try this patch, please use following patch along with
diff --git a/winsup/cygwin/fhandler_tty.cc b/winsup/cygwin/fhandler_tty.cc
index 2b7c667a6..06ac0c5e0 100644
@@ -2413,6 +2413,7 @@ fhandler_pty_master::ioctl (unsigned int cmd, void *arg)
size.X = ((struct winsize *) arg)->ws_col;
size.Y = ((struct winsize *) arg)->ws_row;
+ get_ttyp ()->last_push_time = GetTickCount ();
ResizePseudoConsole (get_pseudo_console (), size);
if (get_ttyp ()->winsize.ws_row != ((struct winsize *) arg)->ws_row
Takashi Yano <firstname.lastname@example.org>
More information about the Cygwin-patches