[PATCH v2] Cygwin: console: Add guard for set/unset xterm compatible mode.

Corinna Vinschen corinna-cygwin@cygwin.com
Tue Feb 18 10:43:00 GMT 2020


On Feb 18 18:12, Takashi Yano wrote:
> - Setting / unsetting xterm compatible mode may cause race issue
>   between multiple processes. This patch adds guard for that.
> ---
>  winsup/cygwin/fhandler.h          |   6 ++
>  winsup/cygwin/fhandler_console.cc | 125 +++++++++++++++++++++---------
>  winsup/cygwin/select.cc           |  22 ++----
>  winsup/cygwin/spawn.cc            |   8 +-
>  4 files changed, 103 insertions(+), 58 deletions(-)

The patch looks good to me, but I'm curious...

Yesterday you wrote that interlocked counting is not a good
solution due to the 'bash -> cmd -> bash' scenario.  What has
changed your mind?


Thanks,
Corinna

-- 
Corinna Vinschen
Cygwin Maintainer
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: not available
URL: <http://cygwin.com/pipermail/cygwin-patches/attachments/20200218/ef0477c1/attachment.sig>


More information about the Cygwin-patches mailing list