[PATCH 1/1] Collect handling of wpixput and wpbuf into a helper class.

Takashi Yano takashi.yano@nifty.ne.jp
Wed Mar 4 01:49:00 GMT 2020

On Tue, 3 Mar 2020 21:03:38 +0100
Hans-Bernhard Bröker wrote:
> OTOH the MS documentation calls this DWORD* an "optional output" 
> argument.  If I'm reading that right, it means it should be fine to just 
> pass NULL to indicate that we don't need it:
> inline void sendOut (HANDLE &handle)
> {
>    WriteConsoleA (handle, buf, ixput, 0, 0);
> }
> The same would apply to all the other calls of WriteConsoleA, it seems.

Yeah, it could be. However, please note that it should be
saparate patch if you remove wn from WriteConsoleA() other
than wpbuf related.

Takashi Yano <takashi.yano@nifty.ne.jp>

More information about the Cygwin-patches mailing list