[PATCH] Cygwin: pty: Prevent meaningless ResizePseudoConsole() calls.

[Corinna Vinschen]

On May 28 22:49, Takashi Yano via Cygwin-patches wrote:
> - This patch prevents to call ResizePseudoConsole() unless the pty
>   is resized.
> ---
>  winsup/cygwin/fhandler_tty.cc | 18 +++++++++---------
>  1 file changed, 9 insertions(+), 9 deletions(-)
> 
> diff --git a/winsup/cygwin/fhandler_tty.cc b/winsup/cygwin/fhandler_tty.cc
> index f29a2c214..b091765b3 100644
> --- a/winsup/cygwin/fhandler_tty.cc
> +++ b/winsup/cygwin/fhandler_tty.cc
> @@ -2615,18 +2615,18 @@ fhandler_pty_master::ioctl (unsigned int cmd, void *arg)
>        *(struct winsize *) arg = get_ttyp ()->winsize;
>        break;
>      case TIOCSWINSZ:
> -      /* FIXME: Pseudo console can be accessed via its handle
> -	 only in the process which created it. What else can we do? */
> -      if (get_pseudo_console () && get_ttyp ()->master_pid == myself->pid)
> -	{
> -	  COORD size;
> -	  size.X = ((struct winsize *) arg)->ws_col;
> -	  size.Y = ((struct winsize *) arg)->ws_row;
> -	  ResizePseudoConsole (get_pseudo_console (), size);
> -	}
>        if (get_ttyp ()->winsize.ws_row != ((struct winsize *) arg)->ws_row
>  	  || get_ttyp ()->winsize.ws_col != ((struct winsize *) arg)->ws_col)
>  	{
> +	  /* FIXME: Pseudo console can be accessed via its handle
> +	     only in the process which created it. What else can we do? */
> +	  if (get_pseudo_console () && get_ttyp ()->master_pid == myself->pid)
> +	    {
> +	      COORD size;
> +	      size.X = ((struct winsize *) arg)->ws_col;
> +	      size.Y = ((struct winsize *) arg)->ws_row;
> +	      ResizePseudoConsole (get_pseudo_console (), size);
> +	    }
>  	  get_ttyp ()->winsize = *(struct winsize *) arg;
>  	  get_ttyp ()->kill_pgrp (SIGWINCH);
>  	}
> -- 
> 2.26.2

Pushed.


Thanks,
Corinna

-- 
Corinna Vinschen
Cygwin Maintainer