[PATCH 09/12] Cygwin: fhandler_fifo::take_ownership: don't set event unnecessarily
Ken Brown
kbrown@cornell.edu
Thu Jul 16 16:19:12 GMT 2020
Don't set update_needed_evt if there's currently no owner. This will
cause unnecessary churn once I'm the owner and am listening for
connections.
---
winsup/cygwin/fhandler_fifo.cc | 5 ++++-
1 file changed, 4 insertions(+), 1 deletion(-)
diff --git a/winsup/cygwin/fhandler_fifo.cc b/winsup/cygwin/fhandler_fifo.cc
index b6e172ddc..fd1695f40 100644
--- a/winsup/cygwin/fhandler_fifo.cc
+++ b/winsup/cygwin/fhandler_fifo.cc
@@ -1186,8 +1186,11 @@ fhandler_fifo::take_ownership ()
return;
}
set_pending_owner (me);
+ /* Wake up my fifo_reader_thread. */
owner_needed ();
- SetEvent (update_needed_evt);
+ if (get_owner ())
+ /* Wake up owner's fifo_reader_thread. */
+ SetEvent (update_needed_evt);
owner_unlock ();
/* The reader threads should now do the transfer. */
WaitForSingleObject (owner_found_evt, INFINITE);
--
2.27.0
More information about the Cygwin-patches
mailing list