[PATCH] fhandler_proc.cc(format_proc_cpuinfo): use _small_sprintf %X for microcode

Corinna Vinschen corinna-cygwin@cygwin.com
Tue Aug 4 08:12:58 GMT 2020


On Aug  4 00:51, Brian Inglis wrote:
> microcode is unsigned long long, printed by _small_sprintf using %x;
> Cygwin32 used last 4 bytes of microcode for next field MHz, printing 0;
> use correct _small_sprintf format %X to print microcode, producing
> correct MHz value under Cygwin32
> ---
>  winsup/cygwin/fhandler_proc.cc | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/winsup/cygwin/fhandler_proc.cc b/winsup/cygwin/fhandler_proc.cc
> index 72ffa89cdc79..9a20c23d4b65 100644
> --- a/winsup/cygwin/fhandler_proc.cc
> +++ b/winsup/cygwin/fhandler_proc.cc
> @@ -833,7 +833,7 @@ format_proc_cpuinfo (void *, char *&destbuf)
>  					 "model\t\t: %d\n"
>  					 "model name\t: %s\n"
>  					 "stepping\t: %d\n"
> -					 "microcode\t: 0x%x\n"
> +					 "microcode\t: 0x%X\n"
>  					 "cpu MHz\t\t: %d.000\n",
>  				 family,
>  				 model,
> -- 
> 2.28.0

Pushed.


Thanks,
Corinna

-- 
Corinna Vinschen
Cygwin Maintainer


More information about the Cygwin-patches mailing list