[PATCH] Cygwin: sigproc.cc: fix typo in comment describing nprocs

Corinna Vinschen corinna-cygwin@cygwin.com
Fri Aug 28 08:37:36 GMT 2020


On Aug 27 18:40, Ken Brown via Cygwin-patches wrote:
> nprocs is the number of children, not the number of deceased children.
> The incorrect comment used to apply to a variable nzombies.  The
> latter was removed in commit 8cb359d9 in 2004, but the comment was
> never updated.
> ---
>  winsup/cygwin/sigproc.cc | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/winsup/cygwin/sigproc.cc b/winsup/cygwin/sigproc.cc
> index a5cf73bde..30c799f8c 100644
> --- a/winsup/cygwin/sigproc.cc
> +++ b/winsup/cygwin/sigproc.cc
> @@ -44,7 +44,7 @@ char NO_COPY myself_nowait_dummy[1] = {'0'};// Flag to sig_send that signal goes
>  #define Static static NO_COPY
>  
>  
> -Static int nprocs;			// Number of deceased children
> +Static int nprocs;			// Number of children
>  Static char cprocs[(NPROCS + 1) * sizeof (pinfo)];// All my children info
>  #define procs ((pinfo *) cprocs)	// All this just to avoid expensive
>  					// constructor operation  at DLL startup
> -- 
> 2.28.0

I have this already in the loop together with other changes in that
code snippet.


Thanks,
Corinna


More information about the Cygwin-patches mailing list