[PATCH 3/3] Remove recursive configure for cygwin

Jon Turney jon.turney@dronecode.org.uk
Fri Oct 23 20:12:21 GMT 2020


On 23/10/2020 10:36, Corinna Vinschen wrote:
>>>>
>>>> Does creating a new subdir called libcygserver just to build the lib
>>>> clean up things, perhaps?
>>>
>>> I did experiment with something like that, but I'm not sure if it makes
>>> things any clearer, as:
>>>
>>> (i) It's the same source files built with/without -D__OUTSIDE_CYGWIN__
> 
> Oh, btw., this is bothering me for a while now.  This may have been
> a nice idea at the time, but wouldn't it be much better to put
> common methods into headers and otherwise split the source between
> client and server code? 
> 
>>> (ii) building libcygserver requires the generated file globals.h
>>
>> I don't actually see a reason to keep this.
>>
>> There's nothing wrong simplifying this stuff, removing mkglobals_h and
>> creating a static version of globals.h inside the source dir.  For
>> instance, defining enum exit_states or enum winsym_t in global.cc just
>> to generate a globals.h from there is kind of weird anyway.  Getting rid
>> of another undocumented perl script and getting rid of the globals.h
>> build rule sounds rather good to me.

I'd really prefer to do those kinds of change as separate patches, to 
maximize the chances of having something that works. :)


More information about the Cygwin-patches mailing list