[PATCH 00/11] testsuite refurbishment

Corinna Vinschen corinna-cygwin@cygwin.com
Fri Nov 6 09:44:50 GMT 2020


On Nov  5 19:47, Jon Turney wrote:
> Fix testsuite Makefile/configure, so I have some idea what it's supposed to
> be doing, prior to cleanup and Automake-ification.
> 
> > $ make check
> [...]
> > # of expected passes            253
> > # of unexpected failures        23
> > # of unexpected successes       1
> > # of expected failures          7
>  
> Future work:
> - Investigate and fix failing tests
> - Tests are re-compiled every time they are run
> - No parallelization of tests
> 
> For ease of reviewing, this patch series doesn't contain changes to
> generated files which would be made by an autoreconf.
> 
> Jon Turney (11):
>   Add testsuite directory to autogen.sh
>   Always configure in testsuite subdirectory
>   Add rule to testsuite Makefile to regenerate it when needed
>   Avoid 'Makefile.in seems to ignore the --datarootdir setting' warning
>   Move adding libltp to VPATH after Makefile.common
>   Define target_builddir autoconf and Makefile variables
>   Detect and use MinGW compilers for testsuite wrappers
>   Use absolute path to libltp includes
>   Check exit code of a test, rather than stdout
>   Set PATH for tests to pick up cygwin0.dll
>   Ensure temporary directory used by tests exists
> 
>  winsup/Makefile.in                      |  16 +-
>  winsup/autogen.sh                       |   2 +-
>  winsup/configure.ac                     |   2 +-
>  winsup/testsuite/Makefile.in            |  31 +-
>  winsup/testsuite/aclocal.m4             | 831 ------------------------
>  winsup/testsuite/autogen.sh             |   4 +
>  winsup/testsuite/configure.ac           |   9 +
>  winsup/testsuite/cygrun.c               |   5 +-
>  winsup/testsuite/winsup.api/cygload.exp |   2 +-
>  winsup/testsuite/winsup.api/winsup.exp  |  24 +-
>  10 files changed, 60 insertions(+), 866 deletions(-)
>  delete mode 100644 winsup/testsuite/aclocal.m4
>  create mode 100755 winsup/testsuite/autogen.sh
> 
> -- 
> 2.29.0

Looks good, please push.


Thanks,
Corinna


More information about the Cygwin-patches mailing list