[PATCH 03/11] syscalls.cc: Fix num_links

Corinna Vinschen corinna-cygwin@cygwin.com
Mon Jan 18 11:01:58 GMT 2021


On Jan 15 14:45, Ben Wijen wrote:
> NtQueryInformationFile on fh_ro needs FILE_READ_ATTRIBUTES
> to succeed.
> ---
>  winsup/cygwin/syscalls.cc | 5 +++--
>  1 file changed, 3 insertions(+), 2 deletions(-)
> 
> diff --git a/winsup/cygwin/syscalls.cc b/winsup/cygwin/syscalls.cc
> index 0e89b4f44..227d1a911 100644
> --- a/winsup/cygwin/syscalls.cc
> +++ b/winsup/cygwin/syscalls.cc
> @@ -767,8 +767,9 @@ _unlink_nt (path_conv &pc, bool shareable)
>        if ((pc.fs_flags () & FILE_SUPPORTS_TRANSACTIONS))
>  	start_transaction (old_trans, trans);
>  retry_open:
> -      status = NtOpenFile (&fh_ro, FILE_WRITE_ATTRIBUTES, &attr, &io,
> -			   FILE_SHARE_VALID_FLAGS, flags);
> +      status = NtOpenFile (&fh_ro,
> +                           FILE_READ_ATTRIBUTES | FILE_WRITE_ATTRIBUTES,
> +                           &attr, &io, FILE_SHARE_VALID_FLAGS, flags);
>        if (NT_SUCCESS (status))
>  	{
>  	  debug_printf ("Opening %S for removing R/O succeeded",
> -- 
> 2.29.2

Oh, right!  Pushed.


Thanks,
Corinna


More information about the Cygwin-patches mailing list