[PATCH 05/11] Cygwin: Move post-dir unlink check

Ben ben@wijen.net
Mon Jan 18 14:31:40 GMT 2021


On 18-01-2021 12:08, Corinna Vinschen via Cygwin-patches wrote:
> On Jan 15 14:45, Ben Wijen wrote:
>> Move post-dir unlink check from
>> fhandler_disk_file::rmdir to _unlink_nt
> 
> Why?  It's not much of a problem, codewise, but the commit message
> could be improved here.
> 
Something like this?
    Cygwin: Move post-dir unlink check
    
    Move post-dir unlink check from
    fhandler_disk_file::rmdir to _unlink_nt
    
    This helps in two ways:
    * Now all checks are in one place
    * Even if a directory is removed through
      _unlink_nt, but not rmdir, the return
      value can be trusted.


More information about the Cygwin-patches mailing list