[PATCH 02/11] syscalls.cc: Deduplicate _remove_r
Mon Jan 18 14:49:27 GMT 2021
On Jan 18 14:51, Ben wrote:
> On 18-01-2021 14:04, Corinna Vinschen via Cygwin-patches wrote:
> > What about this instead? It should be better optimizable:
> * _remove_r should still set reent->_errno
This is redundant:
errno == (*__errno ()) == _REENT->_errno == __getreent ()->errno
So ptr->_errno is already set.
> * _GLOBAL_REENT isn't threadlocal, what about __getreent()
Yeah, that makes sense. Just use the _REENT macro instead.
Care to send the resulting patch?
More information about the Cygwin-patches