[PATCH 05/11] Cygwin: Move post-dir unlink check

Corinna Vinschen corinna-cygwin@cygwin.com
Mon Jan 18 14:52:00 GMT 2021


On Jan 18 15:31, Ben wrote:
> On 18-01-2021 12:08, Corinna Vinschen via Cygwin-patches wrote:
> > On Jan 15 14:45, Ben Wijen wrote:
> >> Move post-dir unlink check from
> >> fhandler_disk_file::rmdir to _unlink_nt
> > 
> > Why?  It's not much of a problem, codewise, but the commit message
> > could be improved here.
> > 
> Something like this?
>     Cygwin: Move post-dir unlink check
>     
>     Move post-dir unlink check from
>     fhandler_disk_file::rmdir to _unlink_nt
>     
>     This helps in two ways:
>     * Now all checks are in one place
>     * Even if a directory is removed through
>       _unlink_nt, but not rmdir, the return
>       value can be trusted.

Sure, looks good.  You don't have to cramp the text into the first 40
cols, 80 is fine.


Thanks,
Corinna


More information about the Cygwin-patches mailing list