[PATCH 08/11] path.cc: Allow to skip filesystem checks

Corinna Vinschen corinna-cygwin@cygwin.com
Tue Jan 19 09:25:31 GMT 2021

On Jan 18 18:15, Ben wrote:
> On 18-01-2021 12:36, Corinna Vinschen via Cygwin-patches wrote:
> > On Jan 15 14:45, Ben Wijen wrote:
> > 
> > Without any code setting the flag, this doesn't seem to make any
> > sense.  At least the commit message should reflect on the reasons
> > for this change.
> > 
> Something like this:
>     path.cc: Allow to skip filesystem checks
>     When file attributes are of no concern, there is no point to query them.
>     This can greatly speedup code which doesn't need it.
>     For example, this can be used to try a path without filesystem checks first
>     and try again with filesystem checks
> If you want, I can also squash some of these related commits.

That's not necessary, but a log msg hint along the lines of "in
preparation of <what follow up patch is doing>" would help.

However, just to be clear here.  While I really appreciate your efforts,
I'm not sure yet if we really *can* skip the filesystem checks.  This is
dangerous but often perpetrated territory.  Trying to work around
certain checks almost always resulted in other problems in the past,
like POSIX/Linux incompatibilities or forgetting to handle Windows
quirks.  A certain callousness and high frustration barrier are


More information about the Cygwin-patches mailing list