[PATCH] Cygwin: getdtablesize: always return OPEN_MAX_MAX

Corinna Vinschen corinna-cygwin@cygwin.com
Mon Feb 1 09:42:19 GMT 2021


On Jan 29 14:23, Ken Brown via Cygwin-patches wrote:
> On 1/28/2021 5:28 PM, Ken Brown via Cygwin-patches wrote:
> > > ...ideally by adding a file include/cygwin/limits.h included by
> > > include/limits.h, which defines __OPEN_MAX et al, as required.
> > 
> > I'm not completely sure I follow.  Do you mean include/cygwin/limits.h
> > should contain
> > 
> >    #define __OPEN_MAX 3200
> > 
> > and include/limits.h should contain
> > 
> >    #define OPEN_MAX __OPEN_MAX ?
> > 
> > For the sake of my education, could you explain the reason for this?
> 
> Trying to answer my own question, I guess the idea is to hide implementation
> details from viewers of limits.h.  Is that right?

Yes, that was the idea, kind of like a poor mans include/bits dir on
Linux...

> I took a stab at this and
> am about to send a patchset.  I'm not sure whether I made a reasonable
> choice of "et al" in "__OPEN_MAX et al".

Sorry, I didn't mean to imply you will have to do that right away.
It was just a thought to move over more values in later patches.


Corinna


More information about the Cygwin-patches mailing list