[PATCH] CYGWIN: Fix resolver debugging output

Lavrentiev, Anton (NIH/NLM/NCBI) [C] lavr@ncbi.nlm.nih.gov
Mon Feb 1 14:23:31 GMT 2021

> Please use %ls, %S is non-standard.


> For instance, write_record appears to handle DNS_TYPE_A,
> but not DNS_TYPE_AAAA.

I can add that, it's not a problem.  But indeed, reparsing of Windows packets,
does miss AAAA (as well as some other types, such as URI -- not sure if Windows
has it, though).

> Would you mind to split this into a patchset with patches for different
> tasks?  ATM I'm a bit concerned about the ntoh{sl} calls, given the
> noticable absence of IPv6 support...

Okay.  BTW, I added ntol/s only for output of *nameserver*'s IPv4:port, because
nameservers are IPv4 (even in glibc, AFAIK).  The _res structure (same in glibc)
has these addresses as "struct in_addr", meaning they are IPv4.  And so there's
no risk of running into any troubles, but reading the IP addresses in debug output
is much easier if they are in native order (and same goes for ports, even more).

More information about the Cygwin-patches mailing list