[PATCH] Cygwin: pty: Attach to stub process when non-cygwin app inherits pcon.

Corinna Vinschen corinna-cygwin@cygwin.com
Mon Mar 8 14:03:04 GMT 2021


On Mar  8 22:14, Takashi Yano via Cygwin-patches wrote:
> - If two non-cygwin apps are started simultaneously, attaching to
>   pseudo console sometimes fails. This is because the second app
>   trys to attach to the process not started yet. This patch avoids
>   the issue by attaching to the stub process rather than the other
>   non-cygwin app.
> ---
>  winsup/cygwin/fhandler_tty.cc | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/winsup/cygwin/fhandler_tty.cc b/winsup/cygwin/fhandler_tty.cc
> index 4358bceec..3bfc8c0c8 100644
> --- a/winsup/cygwin/fhandler_tty.cc
> +++ b/winsup/cygwin/fhandler_tty.cc
> @@ -3104,7 +3104,7 @@ fhandler_pty_slave::setup_pseudoconsole (bool nopcon)
>  		       0, TRUE, DUPLICATE_SAME_ACCESS);
>        CloseHandle (pcon_owner);
>        FreeConsole ();
> -      AttachConsole (p->dwProcessId);
> +      AttachConsole (p->exec_dwProcessId);
>        goto skip_create;
>      }
>  
> -- 
> 2.30.1

Pushed.


Thanks,
Corinna


More information about the Cygwin-patches mailing list