[PATCH] Add support for high-entropy-va flag to peflags.
Corinna Vinschen
corinna-cygwin@cygwin.com
Mon May 17 10:54:28 GMT 2021
Hi Jeremy,
On May 15 12:17, Jeremy Drake via Cygwin-patches wrote:
> This allows for setting, clearing, and displaying the value of the "high
> entropy va" dll characteristics flag.
>
> Signed-off-by: Jeremy Drake <github@jdrake.com>
> ---
> I'm not sure this is the right list for this...
It's not, but given the low traffic, never mind that for this patch.
Thanks for the patch, but I have two nits:
- The patch doesn't apply cleanly with `git am'. Please check again.
- I would prefer a massively reduced patch size, by *not* changing
indentation on otherwise unaffected lines.
I.e., ignore the problem here:
{"dynamicbase", optional_argument, NULL, 'd'},
+ {"high-entropy-va", optional_argument, NULL, 'e'},
...and just add
" -d, --dynamicbase [BOOL] Image base address may be relocated using\n"
+" -e,
+ --high-entropy-va [BOOL] Image is compatible with 64-bit address space\n"
+" layout randomization (ASLR).\n"
With that change I'll apply it and release a new version of rebase soon.
Oh and, btw., there's some problem with DMARC munging with your email
address. Would you mind to attach the git patch instead of inlining
it? I won't accidentally forget to fix your email address in the log
message then :-P
Thanks,
Corinna
More information about the Cygwin-patches
mailing list