[PATCH 2/2] Cygwin: resolver: Targets in SRV DNS responses may not be compressed

Anton Lavrentiev lavr@ncbi.nlm.nih.gov
Tue Jan 18 22:39:16 GMT 2022


RFC2782 clearly says so yet it's a common misconception to perform the
compression in the violation of the standard.  This patch fixes that
---
 winsup/cygwin/libc/minires-os-if.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/winsup/cygwin/libc/minires-os-if.c b/winsup/cygwin/libc/minires-os-if.c
index 8d3178f70..5da1c0c55 100644
--- a/winsup/cygwin/libc/minires-os-if.c
+++ b/winsup/cygwin/libc/minires-os-if.c
@@ -159,6 +159,7 @@ static unsigned char * write_record(unsigned char * ptr, PDNS_RECORD rr,
       PUTSHORT(rr->Data.SRV.wWeight, ptr);
       PUTSHORT(rr->Data.SRV.wPort, ptr);
     }
+    dnptrs = 0;  /* compression not allowed */
     PUTDOMAIN(rr->Data.SRV.pNameTarget, ptr);
     break;
   default:
-- 
2.33.0



More information about the Cygwin-patches mailing list