[PATCH v4] Cygwin: pipe: Avoid deadlock for non-cygwin writer.

Takashi Yano takashi.yano@nifty.ne.jp
Fri Apr 1 08:44:40 GMT 2022


On Wed, 30 Mar 2022 09:17:16 +0900
Takashi Yano wrote:
> On Tue, 29 Mar 2022 08:21:11 -0700 (PDT)
> Jeremy Drake wrote:
> > This block seems to be inside a loop over handles.  Would it make sense to
> > move the `tty_min dummy_tty` through `t->kill_pgrp` lines outside the
> > loop, and set a flag in the loop instead, so the pgrp only needs to be
> > signaled (killed) once rather than for each handle that needs closing?
> 
> Thanks for the advice. I will submit v5 patch reflecting your advice.

I revised the patch again a bit so that __SIGNONCYGCHLD will
be sent only if it is really necessary.

-- 
Takashi Yano <takashi.yano@nifty.ne.jp>


More information about the Cygwin-patches mailing list